refactor(crypto): only allow vendor fields for type 0 & type 6#1931
Merged
faustbrian merged 7 commits intodevelopfrom Jan 3, 2019
Merged
refactor(crypto): only allow vendor fields for type 0 & type 6#1931faustbrian merged 7 commits intodevelopfrom
faustbrian merged 7 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1931 +/- ##
===========================================
+ Coverage 40.48% 40.52% +0.03%
===========================================
Files 350 350
Lines 7564 7569 +5
Branches 1136 1129 -7
===========================================
+ Hits 3062 3067 +5
- Misses 4487 4488 +1
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
spkjp
approved these changes
Jan 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Right now the serialisation and deserialisation assumes that every transaction type can have a vendor field which is not the case, at least I can't come up with any scenario right now why a second signature or vote would need a vendor field.
Types of changes
Checklist