fix(core-api): return the database timestamp instead of deserialised#1957
Merged
fix(core-api): return the database timestamp instead of deserialised#1957
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1957 +/- ##
========================================
Coverage 38.61% 38.61%
========================================
Files 354 354
Lines 7762 7762
Branches 1137 1139 +2
========================================
Hits 2997 2997
Misses 4751 4751
Partials 14 14
Continue to review full report at Codecov.
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The timestamp of the deserialised transaction was used instead of the timestamp from the database by which transactions are sorted.
The problem with that is that the timestamp gets overwritten when a transaction gets forged so the timestamp in the database and serialised transaction differ.
Resolves #1951
Types of changes
Checklist