fix(core-p2p): ip address validation#2045
Merged
faustbrian merged 7 commits intoArkEcosystem:developfrom Jan 31, 2019
spkjp:address-validation
Merged
fix(core-p2p): ip address validation#2045faustbrian merged 7 commits intoArkEcosystem:developfrom spkjp:address-validation
faustbrian merged 7 commits intoArkEcosystem:developfrom
spkjp:address-validation
Conversation
|
@faustbrian @alexbarnsley - please review this pull request in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Codecov Report
@@ Coverage Diff @@
## develop #2045 +/- ##
===========================================
+ Coverage 73.26% 73.31% +0.04%
===========================================
Files 373 373
Lines 8222 8243 +21
Branches 1196 1212 +16
===========================================
+ Hits 6024 6043 +19
Misses 2165 2165
- Partials 33 35 +2
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Jan 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds the ip address fix from #2042 and simplifies the checks we do by moving some stuff into a new helper.
Types of changes
Checklist