Skip to content

fix: Core-SV-009 and Core-SV-010#2042

Merged
faustbrian merged 2 commits intomasterfrom
patch
Jan 31, 2019
Merged

fix: Core-SV-009 and Core-SV-010#2042
faustbrian merged 2 commits intomasterfrom
patch

Conversation

@spkjp
Copy link
Copy Markdown
Contributor

@spkjp spkjp commented Jan 31, 2019

Proposed changes

https://github.com/ArkEcosystem/security-vulnerabilities/blob/master/core/core-sv-009.md
https://github.com/ArkEcosystem/security-vulnerabilities/blob/master/core/core-sv-010.md

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@spkjp spkjp requested review from faustbrian and kristjank January 31, 2019 12:35
@ghost
Copy link
Copy Markdown

ghost commented Jan 31, 2019

@faustbrian @alexbarnsley - please review this pull request in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@faustbrian faustbrian merged commit 8a62f55 into master Jan 31, 2019
@ghost ghost deleted the patch branch January 31, 2019 12:37
@ghost ghost removed the Status: Needs Review label Jan 31, 2019
vasild added a commit that referenced this pull request Feb 11, 2019
…peer-state

* ArkEcosystem/core/develop:
  fix: Core-SV-009 and Core-SV-010 (#2042)
  fix(crypto): expect fee to be number or bignumber
  chore(crypto): bump version
  fix(crypto): add missing bignumber rules
  fix(crypto): use positive rule for number and bignumber
  chore: bump version
  fix: check previous slot
  fix: inactive forgers
  fix(core-api): return the database timestamp instead of deserialised
  fix(core-api): generate valid cache key for block transactions
  fix(core-p2p): prevent the list of peers to become too short (#1829)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants