fix(core-blockchain): invalid timestamp check#2046
Merged
faustbrian merged 1 commit intoArkEcosystem:developfrom Feb 1, 2019
spkjp:invalid-timestamp-check
Merged
fix(core-blockchain): invalid timestamp check#2046faustbrian merged 1 commit intoArkEcosystem:developfrom spkjp:invalid-timestamp-check
faustbrian merged 1 commit intoArkEcosystem:developfrom
spkjp:invalid-timestamp-check
Conversation
|
@faustbrian @alexbarnsley - please review this pull request in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Codecov Report
@@ Coverage Diff @@
## develop #2046 +/- ##
===========================================
+ Coverage 73.31% 73.32% +0.01%
===========================================
Files 373 373
Lines 8243 8247 +4
Branches 1188 1177 -11
===========================================
+ Hits 6043 6047 +4
+ Misses 2168 2166 -2
- Partials 32 34 +2
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Feb 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Timestamp check from #2042 plus unit test.
Types of changes
Checklist