Skip to content

refactor(core-debugger-cli): replace commander.js with @oclif#2049

Merged
spkjp merged 6 commits intodevelopfrom
refactor/oclif-debugger
Feb 1, 2019
Merged

refactor(core-debugger-cli): replace commander.js with @oclif#2049
spkjp merged 6 commits intodevelopfrom
refactor/oclif-debugger

Conversation

@faustbrian
Copy link
Copy Markdown
Contributor

Proposed changes

Resolves #1929

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from spkjp February 1, 2019 08:30
@ghost
Copy link
Copy Markdown

ghost commented Feb 1, 2019

@alexbarnsley @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 1, 2019

Codecov Report

Merging #2049 into develop will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2049      +/-   ##
===========================================
+ Coverage    73.62%   73.69%   +0.06%     
===========================================
  Files          365      366       +1     
  Lines         8202     8223      +21     
  Branches      1165     1188      +23     
===========================================
+ Hits          6039     6060      +21     
  Misses        2131     2131              
  Partials        32       32
Impacted Files Coverage Δ
...es/core-debugger-cli/src/commands/verify-second.ts 100% <100%> (ø) ⬆️
packages/core-debugger-cli/src/commands/command.ts 100% <100%> (ø)
...ackages/core-debugger-cli/src/commands/identity.ts 100% <100%> (ø) ⬆️
packages/core-debugger-cli/src/commands/verify.ts 100% <100%> (ø) ⬆️
...ckages/core-debugger-cli/src/commands/serialize.ts 100% <100%> (ø) ⬆️
...ages/core-debugger-cli/src/commands/deserialize.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77b15a...052f039. Read the comment docs.

@spkjp spkjp merged commit ef563b7 into develop Feb 1, 2019
@ghost ghost deleted the refactor/oclif-debugger branch February 1, 2019 21:14
@ghost ghost removed the Status: Needs Review label Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants