Skip to content

refactor(core-tester-cli): replace commander.js with @oclif#2051

Merged
faustbrian merged 10 commits intodevelopfrom
refactor/oclif-tester
Feb 2, 2019
Merged

refactor(core-tester-cli): replace commander.js with @oclif#2051
faustbrian merged 10 commits intodevelopfrom
refactor/oclif-tester

Conversation

@faustbrian
Copy link
Copy Markdown
Contributor

Proposed changes

Resolves #1934

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost
Copy link
Copy Markdown

ghost commented Feb 1, 2019

@supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost
Copy link
Copy Markdown

ghost commented Feb 1, 2019

@supaiku0 The ci/circleci: test-node10-2 job is failing as of ca3cae8d446868ede6682f3308abb46b063d140b. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian requested a review from spkjp February 1, 2019 13:46
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 2, 2019

Codecov Report

Merging #2051 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #2051   +/-   ##
=======================================
  Coverage     73.8%   73.8%           
=======================================
  Files          367     367           
  Lines         8258    8258           
  Branches      1209    1200    -9     
=======================================
  Hits          6095    6095           
- Misses        2129    2131    +2     
+ Partials        34      32    -2
Impacted Files Coverage Δ
packages/core/src/utils.ts 66.66% <ø> (ø) ⬆️
packages/core-api/src/server.ts 71.42% <100%> (ø) ⬆️
packages/core-test-utils/src/helpers/container.ts 0% <0%> (ø) ⬆️
packages/core-test-utils/src/generators/wallets.ts 14.28% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5bcfe9...63e6e9b. Read the comment docs.

@faustbrian faustbrian merged commit c2c99e6 into develop Feb 2, 2019
@ghost ghost deleted the refactor/oclif-tester branch February 2, 2019 03:18
@ghost ghost removed the Status: Needs Review label Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants