refactor(core-tester-cli): replace commander.js with @oclif#2051
Merged
faustbrian merged 10 commits intodevelopfrom Feb 2, 2019
Merged
refactor(core-tester-cli): replace commander.js with @oclif#2051faustbrian merged 10 commits intodevelopfrom
faustbrian merged 10 commits intodevelopfrom
Conversation
added 4 commits
February 1, 2019 13:22
|
@supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
|
@supaiku0 The ci/circleci: test-node10-2 job is failing as of ca3cae8d446868ede6682f3308abb46b063d140b. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #2051 +/- ##
=======================================
Coverage 73.8% 73.8%
=======================================
Files 367 367
Lines 8258 8258
Branches 1209 1200 -9
=======================================
Hits 6095 6095
- Misses 2129 2131 +2
+ Partials 34 32 -2
Continue to review full report at Codecov.
|
spkjp
approved these changes
Feb 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves #1934
Types of changes
Checklist