feat(core): implement a CLI with @oclif to replace commander#2100
feat(core): implement a CLI with @oclif to replace commander#2100faustbrian merged 84 commits intodevelopfrom
Conversation
|
@air1one @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
|
@faustbrian The ci/circleci: test-node11-1 job is failing as of 8a0e83e3911006452b1a556e41eb9d63f617322c. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #2100 +/- ##
===========================================
+ Coverage 78.92% 79.39% +0.46%
===========================================
Files 330 329 -1
Lines 7973 7920 -53
Branches 1138 1132 -6
===========================================
- Hits 6293 6288 -5
+ Misses 1648 1599 -49
- Partials 32 33 +1
Continue to review full report at Codecov.
|
|
After this change it is no longer possible to override CORE_DB_USERNAME from the environment: Is this intended? |
Proposed changes
Resolves #1582
Resolves https://github.com/ArkEcosystem/core/milestone/5
Types of changes
Checklist