chore(core): remove accidentally committed env variables#2126
Merged
faustbrian merged 1 commit intodevelopfrom Feb 21, 2019
Merged
chore(core): remove accidentally committed env variables#2126faustbrian merged 1 commit intodevelopfrom
faustbrian merged 1 commit intodevelopfrom
Conversation
|
@air1one @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
requested a review
from 
Contributor
|
I also accidentally committed some mods to the env files. It would be more flexible to be able to override the variables from the environment without having to modify files that are under git control. So, I wonder, when this possibility was disabled recently in #2100, was it on purpose? |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The database username variable was accidentally committed when the CLI was merged.
Types of changes
Checklist