fix(core-snapshots): asset import, include rounds table#2502
Merged
faustbrian merged 5 commits intoArkEcosystem:masterfrom Apr 30, 2019
spkjp:fix-snapshot
Merged
fix(core-snapshots): asset import, include rounds table#2502faustbrian merged 5 commits intoArkEcosystem:masterfrom spkjp:fix-snapshot
faustbrian merged 5 commits intoArkEcosystem:masterfrom
spkjp:fix-snapshot
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2502 +/- ##
==========================================
- Coverage 66.07% 65.99% -0.09%
==========================================
Files 400 400
Lines 8614 8628 +14
Branches 436 395 -41
==========================================
+ Hits 5692 5694 +2
- Misses 2877 2890 +13
+ Partials 45 44 -1
Continue to review full report at Codecov.
|
faustbrian
reviewed
Apr 29, 2019
faustbrian
reviewed
Apr 29, 2019
faustbrian
reviewed
Apr 29, 2019
faustbrian
reviewed
Apr 29, 2019
faustbrian
reviewed
Apr 29, 2019
|
The ci/circleci: test-node10-integration-2 job is failing as of fb3c21c78c4328c942df30e016ff45f15d705571. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes assets that were incorrectly imported, because of
decamelizeKeys. This PR also changes theSnapshotManagerto include the rounds table when taking a snapshot since thePeerVerifierdoes not work properly without it. Theoretically we could regenerate the rounds table from the blocks and transactions table alone, but it takes approx. 1 hours for mainnet so this is not an option.This PR invalidates all existing snapshots.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
Checklist