fix(core): jemalloc compatibility for ubuntu 16.04#3567
Merged
faustbrian merged 1 commit intoArkEcosystem:2.6from Mar 4, 2020
alessiodf:jemalloc
Merged
fix(core): jemalloc compatibility for ubuntu 16.04#3567faustbrian merged 1 commit intoArkEcosystem:2.6from alessiodf:jemalloc
faustbrian merged 1 commit intoArkEcosystem:2.6from
alessiodf:jemalloc
Conversation
alessiodf
requested review from
air1one,
faustbrian and
kristjank
as code owners
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
faustbrian
approved these changes
Mar 4, 2020
|
A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
|
Your pull request has been merged. Thank you for your contribution to the ARK Ecosystem. |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@geopsllc reported that Core couldn't find libjemalloc on Ubuntu 16.04.
I reproduced this and it seems
whereisin Ubuntu 16.04 doesn't traverse/usr/lib/{architecture}/to find binaries, whereas 18.04's version does. Since the package manager installs libjemalloc to that directory, Core doesn't find it on 16.04 even when it is properly installed.Replaced
whereiswith output fromgcc --print-search-dirswhich now also works on 16.04 as well as the others (sincegccis always installed as part of the Core installation).Checklist