-
Notifications
You must be signed in to change notification settings - Fork 12
Feature/v6 net10 #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/v6 net10 #480
Conversation
Updated the project to use .NET SDK version 10.0.100, aligning with the latest .NET ecosystem. Upgraded key dependencies, including: - `Microsoft.Extensions.*` packages to version 10.0.0. - `System.Text.Json` to version 10.0.0. - `Microsoft.AspNetCore.*` packages to version 10.0.0. - `Microsoft.CodeAnalysis.NetAnalyzers` to version 10.0.100. Removed legacy and unused dependencies, such as `System.Memory`, `System.Buffers`, and other `System.*` packages, simplifying the dependency graph. Cleaned up transitive dependencies and aligned project files with updated versions. These changes improve maintainability, reduce bloat, and ensure compatibility with the latest .NET runtime. Replaced `WebHostBuilder` with `HostBuilder` for modern hosting setup. Cleaned up unused configurations like `ServicePointManager` settings. Updated `renovate.json` to target .NET 10.0 for dependency management. Simplified dependency graph and improved maintainability.
Upgraded Swashbuckle.AspNetCore packages to 10.x and Microsoft.OpenApi to 2.3.0, enabling OpenAPI 3.1 support. Refactored OpenApi models and references to align with the updated library structure. Removed deprecated filters (e.g., PolymorphismSchemaFilter, SecurityRequirementsOperationFilter) and replaced them with modern Swashbuckle configuration extensions. Enhanced schema filters for nullable types and improved NodaTime type mappings. Simplified Swagger configuration and removed legacy polymorphism support. Performed general code cleanup, including unused imports, null checks, and redundant code removal. Marked obsolete classes and methods with appropriate annotations.
…ntainers-dotnet-10.x' into feature/v6-net10
…vate/microsoft.build.sql-2.x' into feature/v6-net10
Upgraded `Asp.Versioning.OData` to 8.2.0 and `Microsoft.AspNetCore.OData` to 9.4.1, along with related dependencies (`Microsoft.OData.Core`, `Microsoft.OData.Edm`, `Microsoft.OData.ModelBuilder`, and `Microsoft.Spatial`) to their latest compatible versions. Updated version ranges in `packages.lock.json` and project files (`Ark.Tools.AspNetCore.RavenDb.csproj`, `Ark.Tools.AspNetCore.Swashbuckle.csproj`, and `Ark.Tools.AspNetCore.csproj`) to reflect the new versions and ensure compatibility.
Added the following licenses: - CC0-1.0 - LicenseRef-scancode-public-domain
|
have a look |
|
@AndreaCuneo I've opened a new pull request, #483, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the codebase from .NET 8 to .NET 10, including SDK updates, package upgrades, and necessary code changes to support the new versions. The migration includes updating Swashbuckle/OpenAPI to v10, migrating from FluentAssertions to AwesomeAssertions, and removing deprecated code.
- Updated .NET SDK from 8.0.416 to 10.0.100
- Migrated target frameworks from net8.0 to net10.0 (with multi-targeting support in Directory.Build.props)
- Updated Swashbuckle.AspNetCore packages to v10 with breaking API changes
- Migrated test assertions from FluentAssertions to AwesomeAssertions
- Removed deprecated SpecFlow support and obsolete ServicePointManager configuration
Reviewed Changes
Copilot reviewed 100 out of 102 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| global.json, renovate.json | Updated SDK version constraint to 10.0.100 |
| Directory.Build.props | Added multi-targeting support for net8.0 and net10.0 |
| Sample .csproj files | Updated target framework to net10.0 |
| Swashbuckle-related files | Updated for OpenAPI v3.1 and Swashbuckle v10 breaking changes |
| Test files | Migrated from FluentAssertions to AwesomeAssertions |
| README.md | Added migration guide for v6 changes |
| Database .sqlproj | Updated to SDK-based SQL project v2.0.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ark.ReferenceProject/Core/Ark.Reference.Core.WebInterface/Utils/MultiPartJsonOperationFilter.cs
Show resolved
Hide resolved
Ark.ReferenceProject/Core/Ark.Reference.Core.WebInterface/Utils/MultiPartJsonOperationFilter.cs
Show resolved
Hide resolved
|
@copilot review and update the copilot instructions file based on the upgrade to .net10 done here |
|
@AndreaCuneo I've opened a new pull request, #486, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: AndreaCuneo <5227688+AndreaCuneo@users.noreply.github.com>
Update Copilot instructions for .NET 10 migration
|
@copilot add to your instructions to use conventional commits for commit messages |
|
@AndreaCuneo I've opened a new pull request, #487, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: AndreaCuneo <5227688+AndreaCuneo@users.noreply.github.com>
docs: add conventional commits guidelines to Copilot instructions
No description provided.