can_write(): return error code when no tx mailboxes are available. #3829
Conversation
|
Can you please sign https://developer.mbed.org/contributor_agreement/ ? |
|
@0xc0170 - did this already (my mbed username is svogl - how does this link into here?) |
|
LGTM |
|
/morph test |
Prefer rebase to bring it up to date. We will squash this patch, as its just one commit. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@0xc0170 - fine with me as long as it gets fixed :) anything I need to do? |
Please remove this commit from this PR. It should be separate PR. Let us know once done ! |
|
Ok, did not know that the PR would got for HEAD revision; I dropped the commit and merged in the current upstream state. |
|
@0xc0170 -- checks passed, should be ok now. |
|
Thanks for fixing the commits. We will run CI /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
added
release-version: 5.4.1
ready for merge
and removed
needs: CI
release-version: 5.4.1
labels
|
Please rebase instead of merging (updating your branch with master), we will squash this as its just one commit. Thanks |
Ports for Upcoming Targets Fixes and Changes 3716: fix for issue #3715: correction in startup files for ARM and IAR, alignment of system_stm32f429xx.c files ARMmbed/mbed-os#3716 3741: STM32 remove warning in hal_tick_32b.c file ARMmbed/mbed-os#3741 3780: STM32L4 : Fix GPIO G port compatibility ARMmbed/mbed-os#3780 3831: NCS36510: SPISLAVE enabled (Conflict resolved) ARMmbed/mbed-os#3831 3836: Allow to redefine nRF's PSTORAGE_NUM_OF_PAGES outside of the mbed-os ARMmbed/mbed-os#3836 3840: STM32: gpio SPEED - always set High Speed by default ARMmbed/mbed-os#3840 3844: STM32 GPIO: Typo correction. Update comment (GPIO_IP_WITHOUT_BRR) ARMmbed/mbed-os#3844 3850: STM32: change spi error to debug warning ARMmbed/mbed-os#3850 3860: Define GPIO_IP_WITHOUT_BRR for xDot platform ARMmbed/mbed-os#3860 3880: DISCO_F469NI: allow the use of CAN2 instance when CAN1 is not activated ARMmbed/mbed-os#3880 3795: Fix pwm period calc ARMmbed/mbed-os#3795 3828: STM32 CAN API: correct format and type ARMmbed/mbed-os#3828 3842: TARGET_NRF: corrected spi_init() to properly handle re-initialization ARMmbed/mbed-os#3842 3843: STM32L476xG: set APB2 clock to 80MHz (instead of 40MHz) ARMmbed/mbed-os#3843 3879: NUCLEO_F446ZE: Add missing AnalogIn pins on PF_3, PF_5 and PF_10. ARMmbed/mbed-os#3879 3902: Fix heap and stack size for NUCLEO_F746ZG ARMmbed/mbed-os#3902 3829: can_write(): return error code when no tx mailboxes are available ARMmbed/mbed-os#3829
Notes:
Description
When no tx mailbox is available, can_write should return 0. This patch also removes the subsequent if() which is not needed any more and fixes a hard-coded value.