New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heap and stack size for NUCLEO_F746ZG #3902

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
6 participants
@mazimkhan
Contributor

mazimkhan commented Mar 7, 2017

Description

NUCLEO_F746ZG has 319K RAM. But heap size is set to 32K. It is less than 64K minimum required for mbed-tls tls-client example. Moreover, the comment in the linker script says heap is 1/4 and stack is 1/8 of RAM. This is not true. 1/4 of RAM is 79K and 1/8 is 39K. Hence updating heap and stack sizes to correct 1/4 and 1/8 respectively.

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

Related PRs

List related PRs against other branches:

branch PR
other_pr_production link
other_pr_master link

Steps to test or reproduce

Use steps from issue
ARMmbed/mbed-os-example-tls#54 and
ARMmbed/mbed-os-example-tls#52 @

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 7, 2017

Thanks for the fix.

cc @bcostm @adustm @LMESTM @jeromecoutant please review

@0xc0170

0xc0170 approved these changes Mar 7, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 7, 2017

/morph test

@bcostm

This comment has been minimized.

Contributor

bcostm commented Mar 7, 2017

LGTM. Thanks.

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 7, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1651

All builds and test passed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 8, 2017

@mazimkhan How did you test this change?

@mazimkhan

This comment has been minimized.

Contributor

mazimkhan commented Mar 8, 2017

Reproduced this ARMmbed/mbed-os-example-tls#54 and tested the changes with the same.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Mar 8, 2017

@sg- , following on from our discussion earlier, do we want to allow this PR to go through? Especially if we believe we shouldn't have to be updating individual heap and stack sizes for specific targets for IAR?

targets/TARGET_STM/TARGET_STM32F7/TARGET_STM32F746xG/device/TOOLCHAIN_IAR/stm32f746xg.icf Outdated
@@ -20,8 +20,8 @@ define region ITCMRAM_region = mem:[from __region_ITCMRAM_start__ to __region_IT
/* Stack and Heap */
/*Heap 1/4 of ram and stack 1/8*/
define symbol __size_cstack__ = 0x4000;
define symbol __size_heap__ = 0x8000;
define symbol __size_cstack__ = 0x9000;

This comment has been minimized.

@0xc0170

0xc0170 Mar 9, 2017

Member

can you revert the stack size (this will be fixed later for all targets).

@mazimkhan mazimkhan force-pushed the mazimkhan:master branch to bb197b2 Mar 9, 2017

@sg-

This comment has been minimized.

Member

sg- commented Mar 9, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 9, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1667

All builds and test passed!

@sg- sg- removed the needs: work label Mar 9, 2017

@sg- sg- merged commit 88a4baa into ARMmbed:master Mar 9, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has started
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment