Review: maketx --filter changes - #108
Merged
Merged
Conversation
…s vital info about all available filters. Change maketx to use this in its help message.
…lter name, not the filter width, which is now automatically computed. Also some minor changes to ImageBufAlgo::resize to eliminate useless filterwidth parameter.
Contributor
|
Looks good to me. Thanks! |
Contributor
|
Committed into both trunk and 0.10 (with an additional compatibility commit) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eliminates the silly 'width' argument to maketx --filter : now you just specify the filter name, and it chooses the appropriate width. Also augmented the Filter classes with some static methods that let an application query what filters are available and some vital stats about each of them (including a recommended width, whether it is scaling or windowing, and so on.), and some very minor cleanup to ImageBufAlgo::resize to eliminate a redundant parameter.