fix(filesystem): Use 64-bit file offsets on Windows - #5354
Merged
lgritz merged 2 commits intoJul 31, 2026
Conversation
Use _fseeki64 and _ftelli64 for all Windows builds, including MinGW, instead of selecting them only for MSVC. Fixes #5351 Signed-off-by: Mixie <brincv777@gmail.com>
|
|
MinGW defines __int64 as long long, for which functional cast syntax is invalid. Use static_cast so the Windows code compiles with both GCC and MSVC. Signed-off-by: Mixie <brincv777@gmail.com>
lgritz
approved these changes
Jul 31, 2026
lgritz
left a comment
lgritz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for the fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
_fseeki64()and_ftelli64()on all Windows builds. MinGW does notdefine
_MSC_VER, so it previously usedfseeko()andftello(), which canhave 32-bit offsets.
Fixes #5351.
Tests
clang-format --dry-run --Werror src/libutil/filesystem.cppgit diff --checkoiiotool --statsreads the reproducing EXR successfully