Skip to content

Drop pkg_resources import#1994

Merged
apetrynet merged 1 commit intoAcademySoftwareFoundation:mainfrom
antonio-rojas:pkg_resources
Mar 27, 2026
Merged

Drop pkg_resources import#1994
apetrynet merged 1 commit intoAcademySoftwareFoundation:mainfrom
antonio-rojas:pkg_resources

Conversation

@antonio-rojas
Copy link
Copy Markdown
Contributor

It is unused since 17e9297 and no longer exists since setuptools 82

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Feb 24, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: antonio-rojas / name: Antonio Rojas (e4c635a)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.14%. Comparing base (cc649e0) to head (e4c635a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1994      +/-   ##
==========================================
- Coverage   85.15%   85.14%   -0.01%     
==========================================
  Files         181      181              
  Lines       12784    12780       -4     
  Branches     1206     1206              
==========================================
- Hits        10886    10882       -4     
  Misses       1715     1715              
  Partials      183      183              
Flag Coverage Δ
py-unittests 85.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...entimelineio/opentimelineio/console/otioconvert.py 78.02% <ø> (-0.93%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc649e0...e4c635a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@apetrynet apetrynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @antonio-rojas
This looks good to me and should fix #1945

Could you please solve the DCO issue (hints here) and rebase the branch as it seems to be out of date?

@reinecke
Copy link
Copy Markdown
Collaborator

@antonio-rojas Would you mind following these directions to apply DCO signoff to your commits?

Copy link
Copy Markdown
Collaborator

@jhodges10 jhodges10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this is passing DCO, this is approved.

It is unused since 17e9297 and no longer exists since setuptools 82

Signed-off-by: Antonio Rojas <arojas@archlinux.org>
@apetrynet apetrynet merged commit 267fe4b into AcademySoftwareFoundation:main Mar 27, 2026
55 checks passed
@apetrynet
Copy link
Copy Markdown
Contributor

Thank you @antonio-rojas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants