Skip to content

Check if we are dividing by zero when rescaling#2016

Merged
jminor merged 1 commit intoAcademySoftwareFoundation:mainfrom
darbyjohnston:check_divisor
May 1, 2026
Merged

Check if we are dividing by zero when rescaling#2016
jminor merged 1 commit intoAcademySoftwareFoundation:mainfrom
darbyjohnston:check_divisor

Conversation

@darbyjohnston
Copy link
Copy Markdown
Contributor

Add a check to make sure we are not dividing by zero when rescaling.

@darbyjohnston darbyjohnston added the bug A problem, flaw, or broken functionality. label Apr 26, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.50%. Comparing base (c51d995) to head (b38f801).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2016   +/-   ##
=======================================
  Coverage   84.50%   84.50%           
=======================================
  Files         181      181           
  Lines       13223    13225    +2     
  Branches     1202     1202           
=======================================
+ Hits        11174    11176    +2     
  Misses       1866     1866           
  Partials      183      183           
Flag Coverage Δ
py-unittests 84.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/opentime/rationalTime.h 95.91% <100.00%> (+0.08%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51d995...b38f801. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
@jminor jminor merged commit 7adfb27 into AcademySoftwareFoundation:main May 1, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A problem, flaw, or broken functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants