fix(downloads): never surface research-edition releases as the beta - #68
Merged
Conversation
Research builds (e.g. v0.14.0b3-research) are published as prereleases on the same repo, so the newest-prerelease pick would offer them to regular beta users. Allowlist standard version tags instead.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Greptile SummaryThe PR restricts download generation to standard ActivityWatch version tags so special editions cannot be selected as the public beta.
Confidence Score: 5/5The PR appears safe to merge, with no actionable defects identified in the changed release-selection behavior. The allowlist excludes the research-edition suffix as intended while accepting the standard stable and prerelease tag formats used by current and historical releases. Important Files Changed
Reviews (1): Last reviewed commit: "fix(downloads): never surface research-e..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.14.0b3-researchis a published prerelease with a newercreated_atthan standardv0.14.0b3, so on the next site buildupdate-downloads.pywould have picked it as "the latest pre-release" and offered Research Edition builds (privacy filter enabled by default) to regular beta users on /downloads.Fix: filter releases to an allowlist of standard version tags (
^v\d+\.\d+\.\d+(?:(?:a|b|rc)\d+)?$) before selecting stable/prerelease. An allowlist also keeps any future suffixed variants out, not just-research.Test plan
scripts/update-downloads.pyagainst the live API: now selectsStable: v0.13.2; newer pre-release: v0.14.0b3(previously would pickv0.14.0b3-research, the newest prerelease bycreated_at).