feat(classify): optional priority field for category rules - #153
Open
TimeToBuildBob wants to merge 2 commits into
Open
feat(classify): optional priority field for category rules#153TimeToBuildBob wants to merge 2 commits into
TimeToBuildBob wants to merge 2 commits into
Conversation
Match ActivityWatch/aw-server-rust#663: integer `priority`/`weight` on rules, default rank is depth * 10 so values can slot between nesting levels. Existing configs keep their current ordering.
Greptile SummaryThe PR adds optional integer
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Matching category rules] --> B{Explicit priority?}
B -->|Yes| C[Use integer priority]
B -->|No| D[Use category depth times 10]
C --> E{Rank at least current rank?}
D --> E
E -->|Yes| F[Select category]
E -->|No| G[Keep current category]
F --> H[Return highest-ranked match]
G --> H
Reviews (2): Last reviewed commit: "fix(classify): pick category without i64..." | Re-trigger Greptile |
Replace the signed-64-bit Uncategorized rank with Optional[int] so a valid unbounded Python priority below -(2**63) still beats Uncategorized. Git-Session-Id: bob-monitor-aw-core-153
Contributor
Author
|
@greptileai review |
Contributor
Author
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to ActivityWatch/aw-server-rust#663, requested by @ErikBjare.
Optional integer
priority(aliasweight) on categorize rules.depth * 10(depth 1 → 10, depth 2 → 20), so values can slot between nesting levelsaw-server(Python) uses thisaw_transform.classifypath — no separate copyQuery example:
Does not close ActivityWatch/aw-server-rust#597 — WebUI editor field is still a follow-up.