fix(android): update JNI androidQuery bucket name to aw-watcher-android#632
Conversation
…ucket name This fixes an issue introduced in ActivityWatch#628 where the legacy '-test' suffix was dropped from buckets but not from the query.
Greptile SummaryThis PR updates Android bucket lookup to use the current watcher bucket name. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "fix(query): prefer exact match in find_b..." | Re-trigger Greptile |
| // Hardcoded bucket ID for testing | ||
| let bid_android = "aw-watcher-android-test".to_string(); | ||
| // Hardcoded bucket ID | ||
| let bid_android = "aw-watcher-android".to_string(); |
There was a problem hiding this comment.
Unmigrated Buckets Stop Querying
When androidQuery runs before migrateWatcherAndroidBucketNames has renamed existing aw-watcher-android-test... buckets, the new aw-watcher-android filter no longer matches the only stored Android watcher bucket. That makes the JNI query return an error JSON instead of the user's events until the separate migration entry point has run successfully.
|
@TimeToBuildBob review |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #632 +/- ##
==========================================
+ Coverage 70.81% 75.72% +4.90%
==========================================
Files 51 62 +11
Lines 2916 5033 +2117
==========================================
+ Hits 2065 3811 +1746
- Misses 851 1222 +371 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@greptileai review |
|
Code review looks good to me. The two changes complement each other well:
CI is green across all platforms and Greptile gave it 5/5. LGTM. Merge is Erik's call. |
Closes ActivityWatch/aw-android#191
This fixes an issue introduced in #628 where the legacy '-test' suffix was dropped from buckets but not from the query.