Skip to content

build(deps): require aw-core >=0.5.18 for real profile dir isolation - #169

Merged
ErikBjare merged 1 commit into
masterfrom
build/aw-core-0.5.18
Sep 3, 2026
Merged

build(deps): require aw-core >=0.5.18 for real profile dir isolation#169
ErikBjare merged 1 commit into
masterfrom
build/aw-core-0.5.18

Conversation

@ErikBjare

Copy link
Copy Markdown
Member

Final step for aw-server in the #1399 profile stack (per the merge order):

  • aw-core 0.5.18 is on PyPI with the profile dir suffixing (aw-core#149) and Erik's testing-root fallback rule (aw-core#152)
  • Raise aw-core floor ^0.5.8^0.5.18 and update the lock, so --profile data isolation can't silently be a no-op (as merged, feat(profile): add --profile flag and port/settings isolation #167 with aw-core 0.5.17 gave two profiles the same database)
  • Un-skip test_named_profile_config_is_isolated_from_default (was skipif-gated on old aw-core; now runs and passes)

Follow-up worth a separate look (not this PR): per the ruling, isolated profile roots should use bare filenames — aw-server still writes settings-<profile>.json and reads [server-<profile>] sections inside already-isolated roots. Cosmetic-consistent today (aw-qt reads the same scheme), but diverges from the bare-filenames contract aw-core/aw-server-rust/aw-client now follow.

aw-core 0.5.18 ships the AW_PROFILE dir suffixing (#149) and the
testing-root fallback (#152), so --profile data isolation stops being a
no-op. Raise the floor so installs can't resolve an aw-core without it,
and make the dir-isolation test unconditional (it silently skipped on
older aw-core).
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T16:14:50.234628Z c04ca1e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown

Greptile Summary

This PR raises the minimum and locked aw-core version to 0.5.18 so named profiles receive isolated directories, then makes the corresponding isolation test unconditional.

  • Updates pyproject.toml and poetry.lock for aw-core 0.5.18.
  • Records aw-core's updated click and peewee dependency metadata without changing their resolved versions.
  • Removes the obsolete compatibility skip from the named-profile configuration test.

Confidence Score: 5/5

The PR appears safe to merge, with the dependency floor, lockfile, and profile-isolation test aligned.

The supported installation paths enforce aw-core 0.5.18, the updated lock remains compatible with the project's Python and transitive dependency constraints, and no changed-code-triggered failure remains.

Important Files Changed

Filename Overview
pyproject.toml Raises the aw-core dependency floor to the first version providing the required profile-directory isolation.
poetry.lock Locks aw-core 0.5.18 with internally compatible dependency metadata and unchanged resolved click and peewee versions.
tests/test_profile_config.py Runs the named-profile directory-isolation assertion unconditionally now that the required aw-core version is enforced.

Reviews (1): Last reviewed commit: "build(deps): require aw-core >=0.5.18 fo..." | Re-trigger Greptile

@ErikBjare
ErikBjare merged commit 064b8c9 into master Sep 3, 2026
7 checks passed
@ErikBjare
ErikBjare deleted the build/aw-core-0.5.18 branch September 3, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant