Skip to content

Initial query docs#2

Merged
johan-bjareholt merged 7 commits into
masterfrom
query
Jan 25, 2018
Merged

Initial query docs#2
johan-bjareholt merged 7 commits into
masterfrom
query

Conversation

@johan-bjareholt

Copy link
Copy Markdown
Member

No description provided.

@ghost ghost assigned johan-bjareholt Dec 23, 2017
@ghost ghost added the review label Dec 23, 2017

@ErikBjare ErikBjare left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice improvements, just a minor issue.

Comment thread examples/client.py Outdated
# Synchronous example, insert an event
event_data = {"label": "non-heartbeat event"}
now = datetime.now(timezone.utc)
event = Event(timestamp=now, data=shutdown_data)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data=shutdown_data -> data=event_data

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm weird, was pretty certain that i had tested that code but apparently not. Fixed.

Comment thread extending.rst Outdated
ActivityWatch is written to be flexible to be able to gather most types of data.
Except for the included aw-watcher-window and aw-watcher-afk which tracks your application usage and are included by default in ActivityWatch, there are additional so-called :doc:`watchers` for activitywatch.

If there is some kind of data you would want to track but are not

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected end of sentence.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment thread writing-watchers.rst Outdated

Writing watchers for ActivityWatch is pretty easy, all you need is the :code:`aw-client` library.

**NOTE:** These examples runs the client in *testing* mode, which means that it will try to connect to a aw-server in testing mode on the port 5666 instead of the normal 5600.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a .. note:: block here :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@johan-bjareholt

Copy link
Copy Markdown
Member Author

There is still a lot more to add, but since this is a significant improvement and I don't have time to work on it right now I'll merge this for now.

@johan-bjareholt johan-bjareholt merged commit a47ec2a into master Jan 25, 2018
@ghost ghost removed the review label Jan 25, 2018
@johan-bjareholt johan-bjareholt deleted the query branch January 25, 2018 17:43
@ErikBjare

Copy link
Copy Markdown
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants