[pull] master from web-platform-tests:master - #2489
Merged
Merged
Conversation
Bug 2038588, replaced `TrySelectSomething`, so that option selectedness is only dirty via `OnSelectionChanged`. `OnSelectionChanged` returns early unless `mDefaultSelectionSet` is set, and only `DoneAddingChildren` sets it. This means it never runs for a select built by script. Removing the last unselected option from such a combobox, or resetting its form, re-selects the first enabled option but leaves `selectedOptions` stale. This change moves to initialise `mIsDoneAddingChildren` in the constructor. It's already set when the select is not parser-created. The result is that the early return is skipped, allowing the selected option list to become dirty. Differential Revision: https://phabricator.services.mozilla.com/D323244 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2068632 gecko-commit: 48a3fb1cfc3c644dbc0ca689c976b8183502328f gecko-commit-git: 36658b19bd4d5e4f4a44e02fe9050caa5085bc8c gecko-reviewers: emilio
This is still under the same OmitBlurEventOnElementRemoval flag, as those events are fired together with blur/focusout events. Also use an enum instead of a boolean for this behavior. Bug: 41484175 Change-Id: Ib7e6d9c0b3f4b10e20e30328674ab8af1832de37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8313948 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Cr-Commit-Position: refs/heads/main@{#1692334}
The spec says drawElementImage() should use the bounding rect when given negative width or height. Implement this and add tests. We need to check WebGL and WebGPU to see what they expect. Bug: 512509721 Change-Id: Ieb41221d6e30a0daf53fe9cbcd463ef2a6a87807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8265530 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1692361}
Trusted Types essentially applies to a node tree. Consistently use the ContainerNode's ExecutionContext, rather than the ScriptState's (which is the ExecutionContext of the currently executing JavaScript thread). Those are mostly the same, but would differ e.g. a document can reach into an iframe (or vice versa). Bug: 556013783 Change-Id: I0c8eed185aa12d335ea0f1c287bd751817e66be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8339912 Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Cr-Commit-Position: refs/heads/main@{#1692368}
The RuleSet invalidation does selector matching which will reject rules in implicit @scopes when an element has not seen an implicit scope. When we do not simply append sheets, we call ResetStyle() in order to rebuild metadata properly, including the information on Elements whether it has seen an implicit @scope. The problem is that we need that information when doing the selector matching when invalidating for removed stylesheets. Otherwise, we will not invalidate for selectors inside implicit scope rules for any removed stylesheets. Effectively, we need to have the implicit scopes for both the added and removed stylesheets. Add the implicit scopes for the new active stylesheets before doing RuleSet invalidation. Then, if the change is not an append, we reset style and rebuild everything as necessary, including implicit scopes. Bug: 555286423 Change-Id: I08a32b546ca75d22ce47a383c1bb3508d35d11d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8352487 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1692379}
Unskips external/wpt/ai/proofreader/* across AIExpectations_Manifest* and re-enables the includeCorrectionTypes test case now that the dedicated small expert model component is configured. Follows https://crrev.com/i/9691777. Bug: 446717936 Change-Id: I5cdabe0acd916ca307faad0b4c5a5bd8f8c8e5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8262246 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Isaac Ahouma <iahouma@google.com> Cr-Commit-Position: refs/heads/main@{#1681719} Co-authored-by: Isaac Ahouma <iahouma@google.com>
… that do not match spec (#61740)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )