Allow AAP to be non integer#18
Merged
gregorgorjanc merged 2 commits intoAlphaGenes:feat_metafoundersfrom Oct 22, 2024
Merged
Conversation
Changed integer to a float to allow decimal place on input e.g 0.5, 0.45 etc. Previously was forced on input to be an integer (then later turned into a float).
Contributor
Author
|
Apologies, I forgot to tag. @gregorgorjanc and @XingerTang, please review when you can. |
Member
|
@RosCraddock I don't think we need the |
Contributor
|
@gregorgorjanc Normally that function only takes sequence and genotype input so it is originally designed for the integer inputs. |
Member
|
I see. Couldn't we then stick to |
Contributor
Author
|
@gregorgorjanc you're right! I can make the conditional statement on line 67 using the dtype instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small updates to input the alt_allele_prob_file as a float rather than an integer (which is then turned into a float). This now allows the inputting of decimals such as 0.5, 0.45 which previously caused a valueError.