Antalya 26.6: Support for 'time' type in Iceberg - #2129
Conversation
…next commit) --- Original cherry-pick message follows: Merge pull request #1761 from Altinity/bugfix/antalya-26.3/1535_time_type_write_support Support for 'time' type in Iceberg # Conflicts: # src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergWrites.cpp # src/Storages/ObjectStorage/DataLakes/Iceberg/Utils.cpp # tests/integration/test_database_iceberg/test.py
Kept antalya-26.6's nullable-partition Avro union handling in generateManifestFile and routed the PR's Time/Time64 partition-value encoding through the base branch's `make_value_datum` lambda. Kept `getAvroLogicalType` from the PR and antalya-26.6's `static` linkage of `getPartitionField`; dropped test context belonging to `test_cluster_joins`, which does not exist on antalya-26.6.
CI triage for #2129Verdict: 8 failing checks → 1 PR-caused (a clang-tidy nit with a one-line fix), 7 pre-existing/infra. The only thing this PR actually broke is the 🔴 PR-caused (1) — needs a fix
Suggested fix (one line): - UInt32 converted_scale;
+ UInt32 converted_scale = 0;Note: every non-tidy 🟡 Pre-existing on the base branch (5) — not caused by this PRConfirmed by running the same suites on
🟠 Infra / flaky (2) — safe to re-run
Bottom lineThe Time64 / Iceberg-time change looks clean w.r.t. CI — no new test failures are attributable to it. Only the I have the one-line fix ready. How would you like it delivered — a direct commit to 🤖 Generated with Claude Code |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Support for 'time' type in Iceberg, read and write (#1761 by @ianton-ru).
CI/CD Options
Exclude tests:
Regression jobs to run:
Cherry-picked from #1761.
Documentation entry for user-facing changes
Solved #1535
This changes time format,.
Was - seconds from midnight:
Now - time with microseconds