Fix the WizMote Ethernet pairing note and drop em dashes - #1066
Merged
Conversation
The pairing note said the CAST-1 waits 30 seconds on each radio channel, which misread the firmware. In CAST-1_ETH.yaml the scan interval runs every 2 seconds, and the 30000 ms check is an idle threshold, not a per channel dwell. wizmote_last_packet_ms is only set for an already paired MAC, so during pairing it never updates and the device hops channels every couple of seconds, sweeping all 13 in well under a minute. Telling someone to wait a few minutes hides a genuine pairing failure. Also replaces the em dash placeholders in the Sensor Definitions configuration table with n/a. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughThe CAST-1 documentation now describes updated Ethernet pairing timing and uses ChangesCAST-1 Documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WizMote page said pairing on the Ethernet firmware waits 30 seconds on each radio channel and to allow a few minutes. That misreads the firmware.
In
CAST-1_ETH.yamlthe scanintervalis 2 seconds, and the30000ms check is an idle threshold, not a per-channel dwell:wizmote_last_packet_msis only assigned after the early return that rejects any MAC that isn't already paired, so during pairing it never updates. The device hops channels every couple of seconds and sweeps all 13 in well under a minute.Telling someone to wait a few minutes hides a real pairing failure behind expected behavior.
Also replaces the five em dash placeholders in the Sensor Definitions configuration table with
n/a.🤖 Generated with Claude Code
Summary by CodeRabbit