Conversation
…lized view refresh The test used autoStartTx=true which left INSERT data in an uncommitted transaction. MaterializedViewRefresher.fullRefresh() creates a dedicated transaction (joinCurrentTx=false) that cannot see uncommitted data under snapshot isolation, resulting in empty materialized views. Fix: remove autoStartTx, wrap INSERTs in database.transaction() so the data is committed before the view's initial fullRefresh runs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Coverage variation | ✅ -7.51% coverage variation |
| Diff coverage | ✅ ∅ diff coverage |
Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (582167a) 118917 86638 72.86% Head commit (6545f07) 150156 (+31239) 98120 (+11482) 65.35% (-7.51%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3954) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback
There was a problem hiding this comment.
Code Review
This pull request updates the GitHubIssue3878Test class by removing the automatic transaction start configuration and instead wrapping the document insertion commands within an explicit transaction block in the beginTest method. I have no feedback to provide as there were no review comments.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3954 +/- ##
==========================================
+ Coverage 64.00% 64.45% +0.44%
==========================================
Files 1591 1591
Lines 118917 118917
Branches 25271 25271
==========================================
+ Hits 76118 76652 +534
+ Misses 32309 31681 -628
- Partials 10490 10584 +94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…o [skip ci] Bumps [marked](https://github.com/markedjs/marked) from 18.0.2 to 18.0.3. Release notes *Sourced from [marked's releases](https://github.com/markedjs/marked/releases).* > v18.0.3 > ------- > > [18.0.3](markedjs/marked@v18.0.2...v18.0.3) (2026-05-01) > ----------------------------------------------------------------------------------- > > ### Bug Fixes > > * avoid task checkbox for setext heading text ([#3960](https://redirect.github.com/markedjs/marked/issues/3960)) ([2608e81](markedjs/marked@2608e81)) Commits * [`e8dc395`](markedjs/marked@e8dc395) chore(release): 18.0.3 [skip ci] * [`2608e81`](markedjs/marked@2608e81) fix: avoid task checkbox for setext heading text ([#3960](https://redirect.github.com/markedjs/marked/issues/3960)) * [`dba76f6`](markedjs/marked@dba76f6) chore(deps-dev): bump eslint from 10.2.0 to 10.2.1 ([#3953](https://redirect.github.com/markedjs/marked/issues/3953)) * [`015f1eb`](markedjs/marked@015f1eb) chore(deps-dev): bump typescript from 6.0.2 to 6.0.3 ([#3954](https://redirect.github.com/markedjs/marked/issues/3954)) * [`17c06e9`](markedjs/marked@17c06e9) chore: fix building license for docs ([#3952](https://redirect.github.com/markedjs/marked/issues/3952)) * [`55a54b5`](markedjs/marked@55a54b5) chore: Rename LICENSE.md to LICENSE for better compatibility with Bazel tooli... * See full diff in [compare view](markedjs/marked@v18.0.2...v18.0.3) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Summary
GitHubIssue3878TestusedautoStartTx = true, causingbeginTest()to run inside an uncommitted transactionMaterializedViewRefresher.fullRefresh()creates a dedicated transaction withjoinCurrentTx=falsethat cannot see uncommitted data under snapshot isolation — so both materialized views were created emptyautoStartTx, wrap INSERTs indatabase.transaction()so test data is committed before the view's initialfullRefreshruns (matching the pattern inMaterializedViewSQLTest)Test plan
GitHubIssue3878Testnow pass (Tests run: 4, Failures: 0, Errors: 0)🤖 Generated with Claude Code