Add missing application icon on linux#784
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the missing application icon on Linux by ensuring PNG icon files are properly included in the package distribution. The primary goal is to fix icon display issues by updating package configuration files to include PNG files and making some improvements to the CI workflow.
Key changes:
- Updated package configuration to include PNG files in the distribution
- Fixed duplicate PNG entry in package data configuration
- Enhanced GitHub Actions workflow for releases
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| setup.py | Added "*.png" to the data files glob pattern to include PNG icons |
| pyproject.toml | Fixed duplicate PNG entry in package-data configuration |
| .github/workflows/windows_build.yml | Added release configuration options for better CI behavior |
|
|
||
| [tool.setuptools.package-data] | ||
| ardupilot_methodic_configurator = ["*.param", "*.jpg", "*.json", "*.xml", "*.mo", "*.png"] | ||
| ardupilot_methodic_configurator = ["*.param", "*.png", "*.jpg", "*.json", "*.xml", "*.mo", "*.png"] |
There was a problem hiding this comment.
The '*.png' pattern is duplicated in the package-data list. Remove one of the duplicate entries to avoid confusion.
| ardupilot_methodic_configurator = ["*.param", "*.png", "*.jpg", "*.json", "*.xml", "*.mo", "*.png"] | |
| ardupilot_methodic_configurator = ["*.param", "*.png", "*.jpg", "*.json", "*.xml", "*.mo"] |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Test Results 2 files 2 suites 1m 19s ⏱️ Results for commit d382321. |
No description provided.