ChibiOS: add BRD_SAFETYENABLE on all boards #20812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we want it enabled during early boot to prevent incorrect ESC and servo output
andyp1per
approved these changes
May 21, 2022
default BRD_SAFETYENABLE to 0 on boards with no safety switch, which
gives us the same behaviour as before, but users can choose to enable
the safety
this fixes two problems:
- CAN servos and ESCs work on boards with no safety switch
(eg. MatekH743 with CAN)
- during startup we could get spurious outputs before out aircraft
type is setup
|
flew this on 3 vehicles today, CubeOrange, CUAVv5Nano and MatekH743 copter |
|
.. a side point here is that the Cube Orange's now ship with a GPS that does not include a safety switch meaning that all users need to set BRD_SAFETYENABLE = 0. This is probably one for @bugobliterator to comment on. |
|
I can confirm the issue Safety switch Issue on CAN with Matek H743 board is now fixed . tested ok with Matek M9N-F4-3100 & Matek L431 , using Matek H743 WINGV3 as FC. Thanks for this great fix ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default BRD_SAFETYENABLE to 0 on boards with no safety switch, which gives us the same behaviour as before, but users can choose to enable the safety
this fixes two problems: