Double Data Rate on Cube Red with W25 DDR capable External Flash #27574
+53
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like this change will impact the YJUAV_A6SE and the SPRacingH7 note it will likely need SPI clock dropped to 80MHz, and SPEED_HIGH on the GPIO lines |
|
This needs to be off on the Spracing it is very deliberately not turned on as it yields no benefit and is slightly less reliable.Sid did you actually test that this makes a difference? The raw speed is higher but some of the other timing has to be loosened so that the net result is often a washAndySent from my iPhoneOn 17 Jul 2024, at 10:25, Andrew Tridgell ***@***.***> wrote:
@tridge requested your review on: #27574 Double Data Rate on Cube Red with W25 DDR capable External Flash .
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
andyp1per
requested changes
Jul 17, 2024
| {"w25q-dtr", 0xEF, 0x70, SupportedDeviceType::QuadSPI}, | ||
| {"mt25q", 0x20, 0xBA, SupportedDeviceType::QuadSPI, 0}, // https://www.mouser.in/datasheet/2/671/mict_s_a0003959700_1-2290909.pdf | ||
| {"w25q", 0xEF, 0x40, SupportedDeviceType::QuadSPI, 0}, | ||
| {"w25q-dtr", 0xEF, 0x70, SupportedDeviceType::QuadSPIDTR, 0xED}, |
There was a problem hiding this comment.
you need to use a new name here so that the existing boards are unaffected
|
Made changes so there's a selection to turn the DTR feature on or off. |
|
marked a DelayMerge pending some performance testing that shows a real improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives us 60% increase from 100MHz to 160MHz transfer rate