perf(core-database-postgres): drop redundant and add missing index on blocks#1634
Merged
faustbrian merged 1 commit intodevelopfrom Dec 4, 2018
Merged
perf(core-database-postgres): drop redundant and add missing index on blocks#1634faustbrian merged 1 commit intodevelopfrom
faustbrian merged 1 commit intodevelopfrom
Conversation
The "blocks_unique" on (height, generator_public_key) is redundant because we already have an index on (height) alone. Also, we do queries like: SELECT count(*) FROM blocks WHERE generator_public_key = '...'; [1] and thus we need an index on (generator_public_key), add that missing one. The removal of the redundant index does not change timings: selects that return small count: ~500ms selects that return big count: ~500ms The addition of an index on (generator_public_key) changes it to: selects that return small count: ~50ms selects that return big count: ~500ms
Codecov Report
@@ Coverage Diff @@
## develop #1634 +/- ##
===========================================
- Coverage 74.87% 74.74% -0.13%
===========================================
Files 439 439
Lines 7896 7896
Branches 1039 1039
===========================================
- Hits 5912 5902 -10
- Misses 1764 1771 +7
- Partials 220 223 +3
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #1634 +/- ##
===========================================
- Coverage 74.87% 74.74% -0.13%
===========================================
Files 439 439
Lines 7896 7896
Branches 1039 1039
===========================================
- Hits 5912 5902 -10
- Misses 1764 1771 +7
- Partials 220 223 +3
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Dec 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "blocks_unique" on (height, generator_public_key) is redundant
because we already have an index on (height) alone.
Also, we do queries like:
SELECT count(*) FROM blocks WHERE generator_public_key = '...'; [1]
and thus we need an index on (generator_public_key), add that missing
one.
The removal of the redundant index does not change timings:
selects that return small count: ~500ms
selects that return big count: ~500ms
The addition of an index on (generator_public_key) changes it to:
selects that return small count: ~50ms
selects that return big count: ~500ms
Proposed changes
Types of changes
Checklist