New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): rename development to unitnet #2065

Merged
merged 2 commits into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Feb 6, 2019

Proposed changes

Renamed development to unitnet to make it clear that it is meant to run the test suite together with the unitnet network.

Types of changes

  • Other

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 6, 2019

@supaiku0 @air1one - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@faustbrian faustbrian merged commit 5fd79ed into develop Feb 6, 2019

0 of 6 checks passed

ci/circleci: test-node10-0 CircleCI is running your tests
Details
ci/circleci: test-node10-1 CircleCI is running your tests
Details
ci/circleci: test-node10-2 CircleCI is running your tests
Details
ci/circleci: test-node11-0 CircleCI is running your tests
Details
ci/circleci: test-node11-1 CircleCI is running your tests
Details
ci/circleci: test-node11-2 CircleCI is running your tests
Details

@ArkEcosystemBot ArkEcosystemBot deleted the docker branch Feb 6, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 6, 2019

@faustbrian The ci/circleci: test-node11-0 job is failing as of 691118b33f90cc97ab6377879c24aa623fc5809e. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 6, 2019

@faustbrian The ci/circleci: test-node10-0 job is failing as of 691118b33f90cc97ab6377879c24aa623fc5809e. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

vasild added a commit that referenced this pull request Feb 6, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into verify-…
…peer-state

* ArkEcosystem/core/develop:
  chore(docker): rename development to unitnet (#2065)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment