New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): give user requested field priority for sorting #2073

Merged
merged 5 commits into from Feb 7, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Feb 7, 2019

Proposed changes

Regression after 0318bd8

@supaiku0 double check

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 7, 2019

@supaiku0 @air1one - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

faustbrian and others added some commits Feb 7, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #2073 into develop will increase coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2073      +/-   ##
===========================================
+ Coverage    78.46%   78.48%   +0.01%     
===========================================
  Files          331      331              
  Lines         7707     7714       +7     
  Branches      1061     1084      +23     
===========================================
+ Hits          6047     6054       +7     
  Misses        1629     1629              
  Partials        31       31
Impacted Files Coverage Δ
.../src/server/versions/remote/handlers/blockchain.ts 0% <0%> (ø) ⬆️
.../server/versions/internal/handlers/transactions.ts 100% <100%> (ø) ⬆️
packages/core-api/src/repositories/repository.ts 91.11% <100%> (ø) ⬆️
...p2p/src/server/versions/internal/handlers/utils.ts 31.25% <100%> (ø) ⬆️
packages/core-api/src/repositories/transactions.ts 83.64% <91.66%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f1892e...b764711. Read the comment docs.

@faustbrian faustbrian merged commit 7e5382b into develop Feb 7, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/api branch Feb 7, 2019

vasild added a commit that referenced this pull request Feb 7, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into verify-…
…peer-state

* ArkEcosystem/core/develop:
  fix(core-api): give user requested field priority for sorting (#2073)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment