Skip to content

fix(core-api): give user requested field priority for sorting#2073

Merged
faustbrian merged 5 commits intodevelopfrom
fix/api
Feb 7, 2019
Merged

fix(core-api): give user requested field priority for sorting#2073
faustbrian merged 5 commits intodevelopfrom
fix/api

Conversation

@faustbrian
Copy link
Copy Markdown
Contributor

Proposed changes

Regression after 0318bd8

@supaiku0 double check

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost
Copy link
Copy Markdown

ghost commented Feb 7, 2019

@supaiku0 @air1one - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested review from air1one and spkjp February 7, 2019 10:18
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 7, 2019

Codecov Report

Merging #2073 into develop will increase coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2073      +/-   ##
===========================================
+ Coverage    78.46%   78.48%   +0.01%     
===========================================
  Files          331      331              
  Lines         7707     7714       +7     
  Branches      1061     1084      +23     
===========================================
+ Hits          6047     6054       +7     
  Misses        1629     1629              
  Partials        31       31
Impacted Files Coverage Δ
.../src/server/versions/remote/handlers/blockchain.ts 0% <0%> (ø) ⬆️
.../server/versions/internal/handlers/transactions.ts 100% <100%> (ø) ⬆️
packages/core-api/src/repositories/repository.ts 91.11% <100%> (ø) ⬆️
...p2p/src/server/versions/internal/handlers/utils.ts 31.25% <100%> (ø) ⬆️
packages/core-api/src/repositories/transactions.ts 83.64% <91.66%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f1892e...b764711. Read the comment docs.

@faustbrian faustbrian merged commit 7e5382b into develop Feb 7, 2019
@ghost ghost deleted the fix/api branch February 7, 2019 13:43
@ghost ghost removed the Status: Needs Review label Feb 7, 2019
vasild added a commit that referenced this pull request Feb 7, 2019
…peer-state

* ArkEcosystem/core/develop:
  fix(core-api): give user requested field priority for sorting (#2073)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants