Skip to content

chore(docker): changed forging secret and password handling#2075

Merged
faustbrian merged 1 commit intoArkEcosystem:developfrom
adrian69:develop
Feb 7, 2019
Merged

chore(docker): changed forging secret and password handling#2075
faustbrian merged 1 commit intoArkEcosystem:developfrom
adrian69:develop

Conversation

@adrian69
Copy link
Copy Markdown
Collaborator

@adrian69 adrian69 commented Feb 7, 2019

Proposed changes

Changed script to interactively ask for forging secret and password instead of asking the user to put them manually in advance.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

@adrian69 adrian69 requested a review from faustbrian February 7, 2019 12:32
@ghost
Copy link
Copy Markdown

ghost commented Feb 7, 2019

@air1one @faustbrian @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested review from air1one and spkjp February 7, 2019 12:32
@ghost
Copy link
Copy Markdown

ghost commented Feb 7, 2019

@adrian69 Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@faustbrian faustbrian changed the title Changed forging secret and password handling chore(docker): hanged forging secret and password handling Feb 7, 2019
@faustbrian faustbrian changed the title chore(docker): hanged forging secret and password handling chore(docker): changed forging secret and password handling Feb 7, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 7, 2019

Codecov Report

Merging #2075 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2075   +/-   ##
========================================
  Coverage    78.46%   78.46%           
========================================
  Files          331      331           
  Lines         7707     7707           
  Branches      1068     1085   +17     
========================================
  Hits          6047     6047           
  Misses        1629     1629           
  Partials        31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7439e0...624c930. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2075 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2075   +/-   ##
========================================
  Coverage    78.46%   78.46%           
========================================
  Files          331      331           
  Lines         7707     7707           
  Branches      1068     1085   +17     
========================================
  Hits          6047     6047           
  Misses        1629     1629           
  Partials        31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7439e0...624c930. Read the comment docs.

@faustbrian faustbrian merged commit 5f1892e into ArkEcosystem:develop Feb 7, 2019
@ghost ghost removed the Status: Needs Review label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants