New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): changed forging secret and password handling #2075

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
4 participants
@adrian69
Copy link
Collaborator

adrian69 commented Feb 7, 2019

Proposed changes

Changed script to interactively ask for forging secret and password instead of asking the user to put them manually in advance.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

@adrian69 adrian69 requested a review from faustbrian Feb 7, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 7, 2019

@air1one @faustbrian @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot ArkEcosystemBot requested review from air1one and supaiku0 Feb 7, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 7, 2019

@adrian69 Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@faustbrian faustbrian changed the title Changed forging secret and password handling chore(docker): hanged forging secret and password handling Feb 7, 2019

@faustbrian faustbrian changed the title chore(docker): hanged forging secret and password handling chore(docker): changed forging secret and password handling Feb 7, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #2075 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2075   +/-   ##
========================================
  Coverage    78.46%   78.46%           
========================================
  Files          331      331           
  Lines         7707     7707           
  Branches      1068     1085   +17     
========================================
  Hits          6047     6047           
  Misses        1629     1629           
  Partials        31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7439e0...624c930. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #2075 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2075   +/-   ##
========================================
  Coverage    78.46%   78.46%           
========================================
  Files          331      331           
  Lines         7707     7707           
  Branches      1068     1085   +17     
========================================
  Hits          6047     6047           
  Misses        1629     1629           
  Partials        31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7439e0...624c930. Read the comment docs.

@faustbrian faustbrian merged commit 5f1892e into ArkEcosystem:develop Feb 7, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment