refactor(core-container): bind plugin options before registering the plugin#2375
Merged
refactor(core-container): bind plugin options before registering the plugin#2375
Conversation
ghost
added
|
The ci/circleci: test-node11-functional job is failing as of e03ede5c145bacc881a52e49b754f5691031b0b4. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
spkjp
approved these changes
Apr 9, 2019
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves #2371 after #2364 is merged
To-Do
Shared.ConfigmockingTypes of changes
Checklist