refactor(core-p2p): increase network timeouts#2828
Merged
Conversation
vasild
requested review from
air1one,
faustbrian,
kristjank and
spkjp
as code owners
We don't need to be too eager to get the responses from peers in a few seconds. In some cases we will start 25 "parallel" download jobs, each one of which downloads 400 blocks which, if full, could account to a few tens of megabytes per job.
vasild
force-pushed
the
increase-network-timeouts
branch
from
ca62c1e to
280e60c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2828 +/- ##
========================================
Coverage 65.34% 65.34%
========================================
Files 363 363
Lines 8194 8194
Branches 392 427 +35
========================================
Hits 5354 5354
+ Misses 2806 2802 -4
- Partials 34 38 +4
Continue to review full report at Codecov.
|
ghost
mentioned this pull request
spkjp
approved these changes
Jul 26, 2019
ghost
deleted the
ghost
mentioned this pull request
vasild
added a commit
that referenced
this pull request
Aug 2, 2019
…o-db * ArkEcosystem/core/2.6: release: 2.5.0-next.10 (#2852) fix(core-p2p): ensure payload database exists (#2851) release: 2.5.14 release: 2.5.14 (#2849) fix(core-p2p): peer discovery limit (#2850) perf(core-p2p): improve transactions endpoint (#2848) fix(core-api): internal server error caused by invalid orderBy field (#2847) refactor(core-p2p): increase network timeouts (#2828) fix(core-api): return data directly if cache is disabled (#2831) fix(core-utils): add content-type header (#2840) perf(core-database): lookup delegates by key (#2837)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to be too eager to get the responses from peers in a few
seconds. In some cases we will start 25 "parallel" download jobs, each
one of which downloads 400 blocks which, if full, could account to a few
tens of megabytes per job.
A summary of what changes this PR introduces and why they were made.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranchIf adding a new feature, the PR's description includes: