Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crypto): add legacy multisignature schema #3040

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@supaiku0
Copy link
Contributor

commented Oct 8, 2019

Summary

Because of #3008 the asset for legacy multisignatures is now actually stripped off, because it is missing from the schema. Before it errored out early enough to keep the asset intact, which is why it was never an issue.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
@codecov

This comment has been minimized.

Copy link

commented Oct 8, 2019

Codecov Report

Merging #3040 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3040      +/-   ##
===========================================
+ Coverage    65.63%   65.64%   +<.01%     
===========================================
  Files          425      425              
  Lines        11732    11732              
  Branches      1595     1595              
===========================================
+ Hits          7700     7701       +1     
  Misses        3995     3995              
+ Partials        37       36       -1
Impacted Files Coverage Δ
packages/crypto/src/transactions/types/schemas.ts 100% <ø> (ø) ⬆️
packages/core-api/src/plugins/pagination/ext.ts 81.13% <0%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aad9ef...8640a85. Read the comment docs.

@faustbrian faustbrian merged commit 19ad6b4 into develop Oct 8, 2019
83 checks passed
83 checks passed
crypto (10.x)
Details
bridgechain-registration (10.x)
Details
unit (10.x)
Details
crypto (12.x)
Details
bridgechain-registration (12.x)
Details
unit (12.x)
Details
bridgechain-resignation (10.x)
Details
integration (10.x)
Details
bridgechain-resignation (12.x)
Details
integration (12.x)
Details
bridgechain-update (10.x)
Details
e2e (10.x)
Details
bridgechain-update (12.x)
Details
e2e (12.x)
Details
business-registration (10.x)
Details
business-registration (12.x)
Details
business-resignation (10.x)
Details
business-resignation (12.x)
Details
business-update (10.x)
Details
business-update (12.x)
Details
delegate-registration (10.x)
Details
delegate-registration (12.x)
Details
delegate-resignation (10.x)
Details
delegate-resignation (12.x)
Details
htlc-claim (10.x)
Details
htlc-claim (12.x)
Details
htlc-lock (10.x)
Details
htlc-lock (12.x)
Details
htlc-refund (10.x)
Details
htlc-refund (12.x)
Details
ipfs (10.x)
Details
ipfs (12.x)
Details
multi-payment (10.x)
Details
multi-payment (12.x)
Details
multi-signature-registration (10.x)
Details
multi-signature-registration (12.x)
Details
second-signature-registration (10.x)
Details
second-signature-registration (12.x)
Details
transfer (10.x)
Details
transfer (12.x)
Details
vote (10.x)
Details
vote (12.x)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
codeclimate All good!
Details
codecov/patch Coverage not affected when comparing 2aad9ef...8640a85
Details
codecov/project 65.64% (+<.01%) compared to 2aad9ef
Details
security/snyk - __tests__/e2e/package.json (ArkEcosystem) No manifest changes detected
security/snyk - package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-blockchain/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-container/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database-postgres/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-elasticsearch/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-airbrake/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-bugsnag/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-raygun/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-rollbar/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-sentry/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-event-emitter/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-exchange-json-rpc/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-explorer/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-forger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-http-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-interfaces/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-jest-matchers/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-pino/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-signale/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-winston/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-new-relic/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-p2p/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-snapshots/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-state/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-tester-cli/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transaction-pool/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transactions/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-vote-report/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-wallet-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-webhooks/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/crypto/package.json (ArkEcosystem) No manifest changes detected
@faustbrian faustbrian deleted the fix/crypto/legacyMultiSignature-schema branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.