fix(core-transactions): get locks attribute or empty object

[dated]

Summary

Fixes #3212.

Checklist

• Documentation (if necessary)
• Tests (if necessary)
• Ready to be merged

[ghost]

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

[spkjp]

This isn't a proper fix, since having no lock during revert means the lock wasn't applied in the first place. In the linked issue the bug occurs in two different places, during a rollback and during wallet building as part of the bootstrap. The former should be fixed with #3155 since it reapplied the transactions in the wrong order at the end of a rollback which would lead to the issue described. The same seems to be the case for buildWallets during bootstrap.

[dated]

Agreed. It was a dirty patch to get my node started. I didn't think this through obviously :) I was messing around with HTLCs at the time, I am now trying to reproduce the issue. Closing this.

[ghost]

Your pull request has been closed, thank you for trying to solve an issue. If you think it was closed prematurely please provide additional information.