fix(core): remove password flag constraint for core:forger command#3270
Merged
faustbrian merged 1 commit intodevelopfrom Nov 19, 2019
Merged
fix(core): remove password flag constraint for core:forger command#3270faustbrian merged 1 commit intodevelopfrom
faustbrian merged 1 commit intodevelopfrom
Conversation
faustbrian
requested review from
air1one,
kristjank and
spkjp
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #3270 +/- ##
=======================================
Coverage 65.2% 65.2%
=======================================
Files 431 431
Lines 12132 12132
Branches 1633 1633
=======================================
Hits 7911 7911
Misses 4188 4188
Partials 33 33
Continue to review full report at Codecov.
|
spkjp
approved these changes
Nov 19, 2019
ghost
deleted the
ghost
mentioned this pull request
faustbrian
pushed a commit
that referenced
this pull request
Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
bip38constraint from the--passwordflag so that it can be used as documented on docs.ark.io. This makes it possible to run thecore:forgercommand directly instead of the underlying commands.Checklist