refactor(core-transaction-pool): storage#3500
Merged
faustbrian merged 1 commit into3.0from Feb 14, 2020
Merged
Conversation
* Removed table field. Storage class isn't that big and it reduces readability. * Removed Synchronizer. Transactions are added/removed as they arrive/leave. Disk operations aren't that slow (especially on SSDs) to require custom synchronization (memory + dirty + sync intervals). * Removed bulk operations, they aren't necessary once Synchronizer is gone.
rainydio
requested review from
air1one,
faustbrian and
kristjank
as code owners
ghost
added
Codecov Report
@@ Coverage Diff @@
## 3.0 #3500 +/- ##
==========================================
+ Coverage 46.93% 47.15% +0.22%
==========================================
Files 536 535 -1
Lines 13669 13605 -64
Branches 1856 1848 -8
==========================================
Hits 6416 6416
+ Misses 7224 7160 -64
Partials 29 29
Continue to review full report at Codecov.
|
2 tasks
faustbrian
changed the title
faustbrian
approved these changes
Feb 14, 2020
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #3499
Simpler transaction pool storage.
If there are sqlite performance problems then it's better to swap it for lmdb. Synchronization should be handled by database, not manually.
Checklist