Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.0 #3533 +/- ##
==========================================
- Coverage 48.69% 48.07% -0.62%
==========================================
Files 539 548 +9
Lines 13549 13861 +312
Branches 1823 1901 +78
==========================================
+ Hits 6598 6664 +66
- Misses 6922 7168 +246
Partials 29 29
Continue to review full report at Codecov.
|
Contributor
Author
|
Already merged in #3499 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #3482. It's missing catch coverage, because I need to implement logging first. It's difficult to mock otherwise. Also I noticed that it makes more sense to check for transaction size first before trying to validate it.
Checklist