Skip to content

refactor: commonmark internal mailto link #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2021
Merged

refactor: commonmark internal mailto link #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
961fae5
refactor: commonmark internal mailto link
alexbarnsley Oct 7, 2021
bd101e7
uncomment test & add assertions
alexbarnsley Oct 7, 2021
fb11858
add snapshot
alexbarnsley Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/CommonMark/Extensions/Link/LinkRenderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@ private function isInternalLink(string $url): bool
return true;
}

// Emails
if (str_starts_with($url, 'mailto:')) {
return true;
}

return false;
}
}
33 changes: 20 additions & 13 deletions tests/CommonMark/Extensions/Link/LinkRendererTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,24 +18,31 @@
$environment = new Environment();
$environment->addRenderer(Text::class, new TextRenderer());

assertMatchesSnapshot((string) $subject->render(new Link($url, 'Label', 'Title'), new HtmlRenderer($environment)));
$element = $subject->render(new Link($url, 'Label', 'Title'), new HtmlRenderer($environment));

$this->expect($element->getAttribute('target'))->not->toBe('_blank');
assertMatchesSnapshot((string) $element);
})->with([
'https://ourapp.com',
'#heading',
'/path/segment',
'mailto:test@ark.io',
]);

// it('should render external links', function (string $url) {
// $subject = new LinkRenderer();
// $subject->setConfiguration(new Configuration());
it('should render external links', function (string $url) {
$subject = new LinkRenderer();
$subject->setConfiguration(new Configuration());

$environment = new Environment();
$environment->addRenderer(Text::class, new TextRenderer());

// $environment = new Environment();
// $environment->addRenderer(Text::class, new TextRenderer());
$element = $subject->render(new Link($url, 'Label', 'Title'), new HtmlRenderer($environment));

// assertMatchesSnapshot((string) $subject->render(new Link($url, 'Label', 'Title'), new HtmlRenderer($environment)));
// })->with([
// 'https://google.com',
// 'unsupported/relative/url', // is valid, but currently not supported
// 'ftp://google.com',
// '//google.com',
// ]);
$this->expect($element->getAttribute('target'))->toBe('_blank');
assertMatchesSnapshot((string) $element);
})->with([
'https://google.com',
'unsupported/relative/url', // is valid, but currently not supported
'ftp://google.com',
'//google.com',
]);
1 change: 1 addition & 0 deletions ...pshots__/LinkRendererTest__it_should_render_internal_links_with_(mailtotestark.io)__1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<a href="mailto:test@ark.io" title="Title">Label</a>