Skip to content

flake: disable playwright setup - #1400

Merged
PepperLola merged 2 commits into
devfrom
dionkud/flake-remove-playwright
Jul 15, 2026
Merged

flake: disable playwright setup#1400
PepperLola merged 2 commits into
devfrom
dionkud/flake-remove-playwright

Conversation

@0xda157

@0xda157 0xda157 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Currently the playwright used by the nix shell is somehow setup incorrectly (which I tried to fix, unsuccessfully, see SYNTH-209). Temporary disabling it lets bun/npm use the globally installed playwright, which allows me to run the tests.


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@0xda157
0xda157 requested a review from azaleacolburn July 9, 2026 20:46
@0xda157
0xda157 requested review from a team as code owners July 9, 2026 20:46
@0xda157
0xda157 requested a review from PepperLola July 9, 2026 20:46
@0xda157
0xda157 force-pushed the dionkud/flake-remove-playwright branch from 478b9d2 to 3e1583c Compare July 10, 2026 21:20

@PepperLola PepperLola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me if it works for you

@PepperLola
PepperLola enabled auto-merge (squash) July 15, 2026 17:00
@PepperLola
PepperLola merged commit 4fc3bfb into dev Jul 15, 2026
16 checks passed
@PepperLola
PepperLola deleted the dionkud/flake-remove-playwright branch July 15, 2026 17:02
@PepperLola PepperLola mentioned this pull request Jul 16, 2026
BrandonPacewic added a commit that referenced this pull request Jul 17, 2026
* 'dev' of github.com:Autodesk/synthesis: (68 commits)
  Add full asset loading tests `[SYNTH-242]` (#1413)
  chore: style
  feat: add Accel to AHRS and velocity to Accel
  fix: make AHRS angles match real ones from javadoc
  flake: disable playwright setup (#1400)
  hotfix: update remaining old jolt references (#1414)
  fix: add back okay destroys
  chore: remove logging
  chore: removed double frees
  fix: add getters for gyro
  fix: `.npmrc` ignore
  fix: add .npmrc to gitignore
  fix: remove npmrc
  fix: make package caching consistent
  feat: update jolt to use synthesis-adsk remote and switch mirabuf submodule to fork
  fix: make assetpack tests actually fail on problems
  chore: move ignore to top level dir
  chore: global dot ignore
  fix: remove npmrc for github actions
  chore: fix ci failures
  ...
BrandonPacewic added a commit that referenced this pull request Jul 21, 2026
* 'dev' of github.com:Autodesk/synthesis: (140 commits)
  docs: merged duplicate doc that referenced solved issue
  fix: properly dispose of robot bounding meshes
  docs: remove stale reference
  docs: remove stale reference
  Remove Failing Multiplayer Test `[SYNTH-249]` (#1416)
  chore: turn off debug bounding boxes
  docs: update refcounted semantics for `PhysicsMaterial` objects
  fix: spawning new robots doesn't move the old ones' bounding boxes
  fix: oriented boxes are positioned correctly initially
  Add full asset loading tests `[SYNTH-242]` (#1413)
  chore: style
  chore: add conditional warning
  chore: de-clutter warnings
  chore: remove unused imports
  fix(mira tests): add mocks of newly used functions
  feat: add Accel to AHRS and velocity to Accel
  fix: make AHRS angles match real ones from javadoc
  flake: disable playwright setup (#1400)
  hotfix: update remaining old jolt references (#1414)
  fix: handle that error in a better way
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants