Skip to content

Remove Failing Multiplayer Test [SYNTH-249] - #1416

Merged
PepperLola merged 2 commits into
devfrom
colbura/249/remove-multiplayer-test
Jul 17, 2026
Merged

Remove Failing Multiplayer Test [SYNTH-249]#1416
PepperLola merged 2 commits into
devfrom
colbura/249/remove-multiplayer-test

Conversation

@azaleacolburn

Copy link
Copy Markdown
Contributor

Task

SYNTH-249

Symptom

Right now, one of the multiplayer tests tries to test two clients actually connecting. This will time-out on Autodesk WiFi because of the firewall, so it isn't really a very helpful test.

Solution

Remove the test. I'm open to other suggestions though!

Verification

Everything still builds, tests still pass


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@AlexD717 AlexD717 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we still want to test this, you could add a flag to only run it during Github CI (since that doesn't have a firewall), but since we already know that multiplayer doesn't work and are deleting it, I don't think this is particularly important.

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@rutmanz rutmanz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like @AlexD717's suggestion but doesn't really matter because we'll be updating the system soon anyway so this won't really be applicable

@PepperLola
PepperLola merged commit 146b65b into dev Jul 17, 2026
16 checks passed
@PepperLola
PepperLola deleted the colbura/249/remove-multiplayer-test branch July 17, 2026 17:08
BrandonPacewic added a commit that referenced this pull request Jul 21, 2026
* 'dev' of github.com:Autodesk/synthesis: (140 commits)
  docs: merged duplicate doc that referenced solved issue
  fix: properly dispose of robot bounding meshes
  docs: remove stale reference
  docs: remove stale reference
  Remove Failing Multiplayer Test `[SYNTH-249]` (#1416)
  chore: turn off debug bounding boxes
  docs: update refcounted semantics for `PhysicsMaterial` objects
  fix: spawning new robots doesn't move the old ones' bounding boxes
  fix: oriented boxes are positioned correctly initially
  Add full asset loading tests `[SYNTH-242]` (#1413)
  chore: style
  chore: add conditional warning
  chore: de-clutter warnings
  chore: remove unused imports
  fix(mira tests): add mocks of newly used functions
  feat: add Accel to AHRS and velocity to Accel
  fix: make AHRS angles match real ones from javadoc
  flake: disable playwright setup (#1400)
  hotfix: update remaining old jolt references (#1414)
  fix: handle that error in a better way
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants