Desktop: Build the snapshot on Windows - #405
Merged
Merged
Conversation
priethor
marked this pull request as ready for review
July 30, 2026 15:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #404.
This gets the desktop snapshot building on Windows. The builder no longer assembles
wp-clicommands as shell strings, so paths with spaces and quoted seed values are not mangled. A Windows CI job now runs the desktop unit tests and buildssnapshot.zip.The Windows job also caught a POSIX-only assumption in one runtime test, which now explicitly exercises the Linux process path.
Cortext still does not launch on Windows. That needs the bundled PHP runtime.
Why
#404 made the app itself portable, but the snapshot builder still relied on a POSIX shell. This needs to work before we can package Cortext for Windows.
Testing Instructions
apps/desktop. Confirm thatsnapshot.zipis created.CORTEXT_DESKTOP_EXTRA_SEED_COMMANDStopost create --post_type=page --post_title="Hello there" --post_status=publish, build the snapshot, then launch Cortext with a fresh--user-data-dir. Open the new page and confirm that its title is "Hello there", not "Hello".