Skip to content

Desktop: Build the bundled PHP runtime on Windows - #408

Merged
priethor merged 11 commits into
mainfrom
priethor/add/windows-php-runtime
Jul 31, 2026
Merged

Desktop: Build the bundled PHP runtime on Windows#408
priethor merged 11 commits into
mainfrom
priethor/add/windows-php-runtime

Conversation

@priethor

Copy link
Copy Markdown
Collaborator

What

Follow-up to #405.

This lets Cortext build and use its own PHP 8.5 runtime on Windows. CI compiles and verifies php.exe, builds the snapshot with it, and then launches Cortext without a system PHP override. The Windows E2E covers startup, persistence, shutdown, and releasing the runtime port.

macOS keeps its existing runtime flow. Packaging and signing remain separate follow-ups.

Why

#405 made the snapshot builder work on Windows, but the desktop app still could not start there without a bundled PHP runtime. Shipping a known PHP version with Cortext means Windows users will not need to install or configure PHP themselves.

Testing Instructions

  1. On Windows x64 with Visual Studio 2022 and Git for Windows installed, build the bundled PHP runtime from apps/desktop. Confirm that it creates runtime/bin/php.exe and reports PHP 8.5.
  2. Build the snapshot with that runtime, then launch Cortext without setting CORTEXT_PHP_BIN. Confirm that the app opens normally.
  3. Create or edit some content, quit Cortext, and open it again. Confirm that the change is still there.
  4. Quit Cortext and confirm that its php.exe process exits and the runtime port is no longer in use.

@priethor
priethor force-pushed the priethor/add/windows-php-runtime branch from b966a87 to 4d27c10 Compare July 31, 2026 11:43
@priethor
priethor marked this pull request as ready for review July 31, 2026 14:17
@priethor priethor added area: desktop Desktop app, PHP runtime, snapshots, and desktop packaging. type: enhancement Improvement to existing behavior. labels Jul 31, 2026
@priethor
priethor force-pushed the priethor/add/windows-php-runtime branch from 9e6d567 to d31f803 Compare July 31, 2026 19:19
@priethor
priethor merged commit edc31be into main Jul 31, 2026
15 checks passed
@priethor
priethor deleted the priethor/add/windows-php-runtime branch July 31, 2026 19:46
@github-actions github-actions Bot added this to the 0.3.0 milestone Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: desktop Desktop app, PHP runtime, snapshots, and desktop packaging. type: enhancement Improvement to existing behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant