Desktop: Build the bundled PHP runtime on Windows - #408
Merged
Conversation
priethor
force-pushed
the
priethor/add/windows-php-runtime
branch
from
July 31, 2026 11:43
b966a87 to
4d27c10
Compare
priethor
marked this pull request as ready for review
July 31, 2026 14:17
priethor
force-pushed
the
priethor/add/windows-php-runtime
branch
from
July 31, 2026 19:19
9e6d567 to
d31f803
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #405.
This lets Cortext build and use its own PHP 8.5 runtime on Windows. CI compiles and verifies
php.exe, builds the snapshot with it, and then launches Cortext without a system PHP override. The Windows E2E covers startup, persistence, shutdown, and releasing the runtime port.macOS keeps its existing runtime flow. Packaging and signing remain separate follow-ups.
Why
#405 made the snapshot builder work on Windows, but the desktop app still could not start there without a bundled PHP runtime. Shipping a known PHP version with Cortext means Windows users will not need to install or configure PHP themselves.
Testing Instructions
apps/desktop. Confirm that it createsruntime/bin/php.exeand reports PHP 8.5.CORTEXT_PHP_BIN. Confirm that the app opens normally.php.exeprocess exits and the runtime port is no longer in use.