Skip to content

Related posts block - add example#13615

Merged
jeherve merged 2 commits intomasterfrom
add/related-posts-block-example
Oct 2, 2019
Merged

Related posts block - add example#13615
jeherve merged 2 commits intomasterfrom
add/related-posts-block-example

Conversation

@MichaelArestad
Copy link
Contributor

Master issue: #13510

Changes proposed in this Pull Request:

  • Added an example preview to the block in the Inspector.
  • Oh. I also added a description. Heck yes!

Before

image

After

image

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Adding support for a new feature

Testing instructions:

  • Create a new post
  • Click the + to open the Inserter
  • Hover over Related Posts

Proposed changelog entry for your changes:

  • None needed

@MichaelArestad MichaelArestad added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Related Posts [Status] Needs Review This PR is ready for review. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Oct 1, 2019
@MichaelArestad MichaelArestad added this to the 7.9 milestone Oct 1, 2019
@MichaelArestad MichaelArestad requested a review from a team October 1, 2019 22:28
@MichaelArestad MichaelArestad self-assigned this Oct 1, 2019
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against e066bf5

@joanrho
Copy link
Contributor

joanrho commented Oct 1, 2019

heck yeah!

why's the date say Aug 2018? (seems like that's just on my end? strange bc my sandbox site doesn't have any posts from that date 🤔 )

Screen Shot 2019-10-01 at 4 50 47 PM

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello MichaelArestad! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D33476-code before merging this PR. Thank you!

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍
Merging.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Oct 2, 2019
@jeherve jeherve merged commit 993a06c into master Oct 2, 2019
@jeherve jeherve deleted the add/related-posts-block-example branch October 2, 2019 16:25
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Related Posts [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants