Autoloader: Detect filtering of active_plugins#17174
Conversation
|
Scheduled Jetpack release: October 6, 2020. E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17174 Thank you for the great PR description! When this PR is ready for review, please apply the |
kbrown9
left a comment
There was a problem hiding this comment.
This looks great to me! Thanks for the test plugin.
It looks like there's a problem with the E2E tests which has nothing to do with this PR, and we're working on a PR to fix them. We'll rebase/retest/merge this PR as soon as that's fixed.
ad9b0da to
948fa32
Compare
Changes proposed in this Pull Request:
In woocommerce/woocommerce#27608 it became apparent that plugins can filter
active_pluginsin a way that prevents some plugins from being detected by the autoloader. This PR addressed the issue by caching the list inshould_autoloader_reset()as an additional means to evaluating whether or not manifests should be processed again.Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No
Testing instructions:
autoloader-testing.phpfile tomu-plugin. It sets up autoloader globals in a way that pretends the autoloader has been successfully loaded. Without this PR this will result in the entire site becoming inaccessible due to class loading errors, but with this PR, it will work as-expected.Proposed changelog entry for your changes:
active_pluginsoptions that would otherwise have left classes out.