Skip to content

Blocks: switch all blocks to be registered using new package#17263

Merged
jeherve merged 4 commits into
masterfrom
use/blocks-package-registration
Oct 1, 2020
Merged

Blocks: switch all blocks to be registered using new package#17263
jeherve merged 4 commits into
masterfrom
use/blocks-package-registration

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Sep 25, 2020

Changes proposed in this Pull Request:

  • Following Blocks: add block registration to package #17167, we can now switch all blocks to use the method introduced in the Blocks package.
  • We can also deprecate the old method.
  • There were old registration methods in Jetpack_Gutenberg that have been deprecated for more than a year already, and are not used in Jetpack anymore. I've removed them for good.
  • I've updated the template used when creating new blocks via WP Cli, so it uses the new method as well.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Go to Posts > Add New
  • In your browser console, check Jetpack_Editor_Initial_State.available_blocks: it should return all expected blocks, and no errors should appear in your logs.
  • Tests should pass.
  • You should be able to use blocks just like before.

Proposed changelog entry for your changes:

  • N/A

@jeherve jeherve added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Pri] Normal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Package] Blocks labels Sep 25, 2020
@jeherve jeherve added this to the 9.1 milestone Sep 25, 2020
@jeherve jeherve self-assigned this Sep 25, 2020
@jeherve jeherve mentioned this pull request Sep 25, 2020
Closed
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Sep 25, 2020 •
edited
Loading

Scheduled Jetpack release: October 6, 2020.
Scheduled code freeze: September 29, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17263

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 5d90170

@jeherve jeherve added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Sep 25, 2020
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Sep 25, 2020

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D50185-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

fgiannar
fgiannar previously approved these changes Sep 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@fgiannar fgiannar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Tested using the instructions and works as expected 👍

@fgiannar fgiannar added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Sep 28, 2020
@jeherve
Blocks: switch all blocks to be registered using new package
53eca0b
@jeherve
Update template so future blocks follow the new pattern
0caa682
@jeherve
Deprecate old method in Jetpack_Gutenberg class
99b7b90 
There were old registration methods in there that have been deprecated for more than a year already, and are not used in Jetpack anymore. I've removed them for good.
@jeherve jeherve force-pushed the use/blocks-package-registration branch from 96065a5 to 99b7b90 Compare September 29, 2020 16:15
@jeherve
Copy link
Copy Markdown
Member Author

jeherve commented Sep 29, 2020

@fgiannar Do you think you could give it another look? I had to rebase following a8b9e2e.

Thank you!

@jeherve jeherve added [Status] Needs Review This PR is ready for review. and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Sep 29, 2020
anomiex
anomiex requested changes Sep 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than one doc mistake.

Comment thread class.jetpack-gutenberg.php Outdated
@anomiex anomiex added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Sep 29, 2020
@jeherve @anomiex
Update class.jetpack-gutenberg.php
5d90170 
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
@jeherve jeherve removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Sep 30, 2020
@jeherve jeherve added the [Status] Needs Review This PR is ready for review. label Sep 30, 2020
anomiex
anomiex approved these changes Sep 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Basic manual testing as suggested also seemed ok, although I didn't get too in depth with it.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Oct 1, 2020
@jeherve jeherve merged commit ebec0a8 into master Oct 1, 2020
@jeherve jeherve deleted the use/blocks-package-registration branch October 1, 2020 07:38
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 1, 2020
@jeherve
Copy link
Copy Markdown
Member Author

jeherve commented Oct 6, 2020

r214736-wpcom

@jeherve jeherve mentioned this pull request Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anomiex anomiex anomiex approved these changes

@fgiannar fgiannar fgiannar left review comments

@georgestephanis georgestephanis Awaiting requested review from georgestephanis

Assignees

@jeherve jeherve

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Package] Blocks [Pri] Normal Touches WP.com Files

Projects

None yet

Milestone

9.1

Development

Successfully merging this pull request may close these issues.

5 participants

@jeherve @jetpackbot @matticbot @anomiex @fgiannar